Optional subsystems #648
Open
Optional subsystems #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Users can develop alternative components and integrate them as subsystems with the existing platform.\n", | ||
| "\n", | ||
| "## External Mass\n", | ||
| "Specifying the `external` mass method disables Aviary's core mass group. This allows for external subsystems to completely replace these calculations." |
There was a problem hiding this comment.
Maybe we should stress that, yeah, this replaces all mass calculations, so you don't want to use it for subsystem mass.
Also, it might be worth mentioning that, to replace the mass subsystem for the sizing problem, your new mass group needs to compute the Aircraft.Design.OPERATING_MASS and Aircraft.CrewPayload.TOTAL_PAYLOAD_MASS, which feed into the downstream constraints.
(Note: might need to check what the gasp mass feeds into the downstream components too.)
|
|
||
| if code_origin is GASP: | ||
| aero_group = PreMissionAero() | ||
| if method != 'external': |
There was a problem hiding this comment.
Might be cleaner to do:
if method is 'external':
return None
That would remove the need to indent the entire rest of the method by 4 spaces. Just a thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extends the capability for a subsystem to be "skipped" via the
externalmethod flag inphase_infoto geometry and mass. Theexternalmethod also now skips both pre-mission and mission.Backwards incompatibilities
None
New Dependencies
None